-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for the plugins.query.field_type_tolerance setting (#1300) #3118
Added documentation for the plugins.query.field_type_tolerance setting (#1300) #3118
Conversation
Signed-off-by: Norman Jordan <[email protected]>
docs/user/admin/settings.rst
Outdated
|
||
Update Settings Request:: | ||
|
||
sh$ curl -sS -H 'Content-Type: application/json' -X PUT 'localhost:9200/_cluster/settings?pretty' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could u follow plugins.query.size_limit setting doc style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used that style for the commands to update the setting.
docs/user/admin/settings.rst
Outdated
This setting controls whether preserve arrays. If this setting is set to false, then an array is reduced | ||
to the first non array value of any level of nesting. | ||
|
||
If you have an index with the following value for a field:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc is exectuable, you can run ppl/sql query directly. for example, https://github.com/opensearch-project/sql/blob/5dafb2fc5960e0a1edff70a089a5390519fc909c/docs/user/ppl/cmd/eval.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reworked the documentation. It still does not actually run the queries, although they are run for other files such as user/beyond/partiql.rst
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could u add limitation of this setting. for instance, expression will failed.
Signed-off-by: Norman Jordan <[email protected]>
Signed-off-by: Norman Jordan <[email protected]>
@penghuo I added a limitations section. |
Signed-off-by: Norman Jordan <[email protected]>
Signed-off-by: Norman Jordan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
#1300) (#3118) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit 9bb4c08) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#1300) (#3118) (#3143) (cherry picked from commit 9bb4c08) Signed-off-by: Norman Jordan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Add documentation for the
plugins.query.field_type_tolerance
setting.Related Issues
Resolves #1300
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.