Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport] Backport #2981 to 2.x #3101

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Oct 23, 2024

Description

Backport #2981

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…nation query (opensearch-project#2981)

* Adding PIT for pagination queries in new SQL engine code paths

Signed-off-by: Manasvini B S <[email protected]>

* Fix legacy code using scroll API instead of PIT for batch physical operator

Signed-off-by: Manasvini B S <[email protected]>

* Fix local debugger issue

Signed-off-by: Manasvini B S <[email protected]>

* Refactor integ-tests data for PIT and fix unit tests

Signed-off-by: Manasvini B S <[email protected]>

* Address feedback comments

Signed-off-by: Manasvini B S <[email protected]>

* Adding test coverage

Signed-off-by: Manasvini B S <[email protected]>

---------

Signed-off-by: Manasvini B S <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
@Swiddis Swiddis force-pushed the backport-2981-to-2x branch from 382bb91 to f702281 Compare October 23, 2024 17:56
@Swiddis Swiddis added v2.18.0 Issues targeting release v2.18.0 backport 2.18 labels Oct 23, 2024
@Swiddis Swiddis merged commit f6ca54c into opensearch-project:2.x Oct 23, 2024
15 of 26 checks passed
@Swiddis Swiddis deleted the backport-2981-to-2x branch October 23, 2024 19:34
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
* Adding PIT for pagination queries in new SQL engine code paths

* Fix legacy code using scroll API instead of PIT for batch physical operator

* Fix local debugger issue

* Refactor integ-tests data for PIT and fix unit tests

* Address feedback comments

* Adding test coverage

---------

Signed-off-by: Manasvini B S <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
(cherry picked from commit f6ca54c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.18 feature v2.18.0 Issues targeting release v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants