-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Job API #2070
Create Job API #2070
Conversation
3ee5fff
to
d094cb7
Compare
Codecov Report
@@ Coverage Diff @@
## feature/job-apis #2070 +/- ##
======================================================
+ Coverage 96.36% 96.57% +0.21%
- Complexity 4643 4696 +53
======================================================
Files 425 433 +8
Lines 12106 12387 +281
Branches 832 847 +15
======================================================
+ Hits 11666 11963 +297
+ Misses 431 413 -18
- Partials 9 11 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d094cb7
to
de26f1e
Compare
spark/src/main/java/org/opensearch/sql/spark/client/EmrServerlessClientImpl.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/jobs/JobManagementService.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/client/EmrServerlessClient.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/client/EmrServerlessClientImpl.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfig.java
Show resolved
Hide resolved
b55d3c5
to
cbb0c14
Compare
db73143
to
26bee6c
Compare
2268c9c
to
8d62bec
Compare
@vamsi-amazon can u plz add a swagger file for a consolidated view and documentation for this API ? |
spark/src/main/java/org/opensearch/sql/spark/data/constants/SparkConstants.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/data/constants/SparkConstants.java
Show resolved
Hide resolved
...k/src/main/java/org/opensearch/sql/spark/transport/TransportGetQueryResultRequestAction.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/jobs/OpensearchJobMetadataStorageService.java
Outdated
Show resolved
Hide resolved
String sparkExecutionEngineConfigString = | ||
settings.getSettingValue(SPARK_EXECUTION_ENGINE_CONFIG); | ||
SparkExecutionEngineConfig sparkExecutionEngineConfig = | ||
AccessController.doPrivileged( | ||
(PrivilegedAction<SparkExecutionEngineConfig>) | ||
() -> | ||
SparkExecutionEngineConfig.toSparkExecutionEngineConfig( | ||
sparkExecutionEngineConfigString)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the construct of SparkExecutionEngine should independent of JobExecutorService.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SparkExecutionEngineConfig contains applicationId which can change and it is picked up runtime during query execution. Probably I need to split up the settings.
spark/src/main/java/org/opensearch/sql/spark/jobs/JobExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
Signed-off-by: Vamsi Manohar <[email protected]>
b6a5ceb
to
257fb50
Compare
@YANG-DB will address this in a separate task. |
257fb50
to
3c41c74
Compare
Signed-off-by: Vamsi Manohar <[email protected]>
3c41c74
to
f96a1a5
Compare
525a0ae
into
opensearch-project:feature/job-apis
* Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]>
* Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]>
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]>
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit ae10857) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Glue datasource support (#2055) * Initial commit of new job APIs (#2050) * Create Job API (#2070) * Create Job API * Refactor to Async Query API --------- * Cancel Job API (#2126) * Add tags to the emr jobs based on the query types (#2150) --------- (cherry picked from commit ae10857) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Fix response codes returned Signed-off-by: Derek Ho <[email protected]> * Remove @opensearch datasource, update with new type Signed-off-by: Derek Ho <[email protected]> * Spotless Apply Signed-off-by: Derek Ho <[email protected]> * Fix tests Signed-off-by: Derek Ho <[email protected]> * Revert change back to json string Signed-off-by: Derek Ho <[email protected]> * Update tests to use JSON string literal instead of formatting Signed-off-by: Derek Ho <[email protected]> * Update IT Signed-off-by: Derek Ho <[email protected]> * Fix show datsources IT Signed-off-by: Derek Ho <[email protected]> * Remove files from merge Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]>
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Fix response codes returned Signed-off-by: Derek Ho <[email protected]> * Remove @opensearch datasource, update with new type Signed-off-by: Derek Ho <[email protected]> * Spotless Apply Signed-off-by: Derek Ho <[email protected]> * Fix tests Signed-off-by: Derek Ho <[email protected]> * Revert change back to json string Signed-off-by: Derek Ho <[email protected]> * Update tests to use JSON string literal instead of formatting Signed-off-by: Derek Ho <[email protected]> * Update IT Signed-off-by: Derek Ho <[email protected]> * Fix show datsources IT Signed-off-by: Derek Ho <[email protected]> * Remove files from merge Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Vamsi Manohar <[email protected]> (cherry picked from commit 5ce1bab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Glue datasource support (#2055) * Initial commit of new job APIs (#2050) * Create Job API (#2070) * Create Job API * Refactor to Async Query API --------- * Cancel Job API (#2126) * Fix response codes returned * Remove @opensearch datasource, update with new type * Spotless Apply * Fix tests * Revert change back to json string * Update tests to use JSON string literal instead of formatting * Update IT * Fix show datsources IT * Remove files from merge --------- (cherry picked from commit 5ce1bab) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vamsi Manohar <[email protected]>
Description
plugins.query.executionengine.spark.config
config. Once the customer updates the setting, user needs a domain restart to enable Job APIs.[Suggestions are welcome]Sample Request Responses.
Job Creation API
Job Result API:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.