-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency resolution commons-lang3 #2049
Conversation
Signed-off-by: Vamsi Manohar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2049 +/- ##
=========================================
Coverage 97.28% 97.28%
Complexity 4624 4624
=========================================
Files 409 409
Lines 11943 11943
Branches 828 828
=========================================
Hits 11619 11619
Misses 317 317
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Have feedback on the report? Share it here. |
@@ -113,6 +113,7 @@ allprojects { | |||
configurations.all { | |||
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib:1.6.0" | |||
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0" | |||
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vamsi-amazon I believe you need to exclude the commons-lang3
since it is part of core :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta thanks will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta can i find all the dependencies in core at one place?
should i go through all the gradle files or build and look into libs folder?
@@ -113,6 +113,7 @@ allprojects { | |||
configurations.all { | |||
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib:1.6.0" | |||
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0" | |||
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try please that:
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0' | |
exclude(group: "org.apache.commons", module: "commons-lang3") |
@vamsi-amazon please hold on with this change, the revert is coming opensearch-project/OpenSearch#9833 |
Closing as this is not required anymore. |
Description
Fixes build issue with commons-lang3
Force Resolution to 3.13.0 version.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.