Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency resolution commons-lang3 #2049

Closed

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Sep 6, 2023

Description

Fixes build issue with commons-lang3
Force Resolution to 3.13.0 version.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2049 (feb65bf) into main (24e01d6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2049   +/-   ##
=========================================
  Coverage     97.28%   97.28%           
  Complexity     4624     4624           
=========================================
  Files           409      409           
  Lines         11943    11943           
  Branches        828      828           
=========================================
  Hits          11619    11619           
  Misses          317      317           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Have feedback on the report? Share it here.

@@ -113,6 +113,7 @@ allprojects {
configurations.all {
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib:1.6.0"
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0"
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vamsi-amazon I believe you need to exclude the commons-lang3 since it is part of core :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta thanks will look into it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta can i find all the dependencies in core at one place?
should i go through all the gradle files or build and look into libs folder?

@@ -113,6 +113,7 @@ allprojects {
configurations.all {
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib:1.6.0"
resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0"
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try please that:

Suggested change
resolutionStrategy.force 'org.apache.commons:commons-lang3:3.13.0'
exclude(group: "org.apache.commons", module: "commons-lang3")

@reta
Copy link
Contributor

reta commented Sep 6, 2023

@vamsi-amazon please hold on with this change, the revert is coming opensearch-project/OpenSearch#9833

@vmmusings vmmusings mentioned this pull request Sep 7, 2023
23 tasks
@vmmusings
Copy link
Member Author

Closing as this is not required anymore.

@vmmusings vmmusings closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants