add ssl bundle support for autoconfigured opensearch client #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to configure SSL Bundle using
opensearch.restclient.ssl.bundle
.Note: the certificate in integration tests is from opensearch security plugin's demo config (https://github.com/opensearch-project/security/blob/main/src/main/java/org/opensearch/security/tools/democonfig/Certificates.java#L157), if the certificate is changed in a future version then the integration test would probably break.
Looked at the SSL hot reload, but implementing it doesn't look that straight forward:
DefaultSingletonBeanRegistry
(could re-create the RestClient bean), but that doesn't really work because it would not effect the already autowired/injected beans.Where should I document that hot reload is not supported? The documentation for available properties is in javadoc, but I can't add anything to the
restclient.ssl.bundle
because the class is from Elasticsearch. Thought about addingRestclient
toOpenSearchProperties
, but that would be breaking change in projects that do something likeElasticsearchProperties.Restclient restclientProperties = openSearchProperties.getRestclient()
.Issues Resolved
resolve #396
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.