Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SafeSerializationUtils for better performance #4973

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

shikharj05
Copy link
Contributor

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]
#4760

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]
UTs

Check List

  • New functionality includes testing
  • [NA] New functionality has been documented
  • [NA] New Roles/Permissions have a corresponding security dashboards plugin PR
  • [NA] API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (79a3299) to head (50be83b).

Files with missing lines Patch % Lines
...earch/security/support/SafeSerializationUtils.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4973      +/-   ##
==========================================
- Coverage   71.48%   71.41%   -0.08%     
==========================================
  Files         334      334              
  Lines       22552    22556       +4     
  Branches     3590     3589       -1     
==========================================
- Hits        16122    16109      -13     
- Misses       4639     4654      +15     
- Partials     1791     1793       +2     
Files with missing lines Coverage Δ
...earch/security/support/SafeSerializationUtils.java 86.66% <88.88%> (+23.03%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwperks cwperks added backport 2.x backport to 2.x branch v2.19.0 Issues targeting release v2.19.0 labels Dec 18, 2024
@cwperks cwperks merged commit 2f870c7 into opensearch-project:main Dec 18, 2024
39 of 40 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 18, 2024
Signed-off-by: shikharj05 <[email protected]>
(cherry picked from commit 2f870c7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.19.0 Issues targeting release v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG/performance] Serialization/Deserialization check for safe classes adds performance overhead
5 participants