Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding alerting comments security actions to roles.yml #4699

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

toepkerd
Copy link
Contributor

@toepkerd toepkerd commented Sep 3, 2024

Description

Adding new alerting comments security permissions to existing alerting plugin roles for new Alerting Comments feature: opensearch-project/alerting#1561

  • Category: Addition as part of new feature
  • Why these changes are required?: to ensure proper and intended permissioning of comments in the alerting plugin
  • What is the old behavior before changes and new behavior after changes?: before the changes, there was no way to specify what users and what roles had access to what comments. This change allows for that to happen.

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.
Not a backport PR, but would like this PR backported to 2.15

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
New permissions are added but are best included under existing alerting plugin roles

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (6735b5c) to head (a59345f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4699      +/-   ##
==========================================
+ Coverage   65.20%   65.25%   +0.04%     
==========================================
  Files         318      318              
  Lines       22327    22327              
  Branches     3591     3591              
==========================================
+ Hits        14558    14569      +11     
+ Misses       5971     5960      -11     
  Partials     1798     1798              

see 3 files with indirect coverage changes

@DarshitChanpura DarshitChanpura merged commit 0ee1cda into opensearch-project:main Sep 3, 2024
42 checks passed
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Sep 3, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Dennis Toepker <[email protected]>
Co-authored-by: Dennis Toepker <[email protected]>
(cherry picked from commit 0ee1cda)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants