Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim build fix for PluginSubject related changes #4690

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 28, 2024

Description

This PR fixes compilation issues due to a change in the IdentityPlugin interface introduced in opensearch-project/OpenSearch#14630

There is a PR open on this repo to implement the extension points as intended, but the PR will need some time for thorough review.

This PR is an interim change to ensure that the plugin compiles. The code is not currently used and guarded by the identity feature flag: opensearch.experimental.feature.identity.enabled

The PluginSubject being introduced in this PR is a noop and simply stashes the ThreadContext.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

Issues Resolved

Related to: #4439

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (0b66f48) to head (2715e0b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...pensearch/security/identity/NoopPluginSubject.java 0.00% 6 Missing ⚠️
.../opensearch/security/OpenSearchSecurityPlugin.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4690      +/-   ##
==========================================
- Coverage   65.26%   65.23%   -0.03%     
==========================================
  Files         317      318       +1     
  Lines       22320    22327       +7     
  Branches     3591     3591              
==========================================
- Hits        14568    14566       -2     
- Misses       5953     5964      +11     
+ Partials     1799     1797       -2     
Files with missing lines Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.47% <0.00%> (-0.12%) ⬇️
...pensearch/security/identity/NoopPluginSubject.java 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@cwperks
Copy link
Member Author

cwperks commented Aug 28, 2024

CI checks will pass after min distribution is updated

@cwperks cwperks added the backport 2.x backport to 2.x branch label Aug 29, 2024
@cwperks cwperks merged commit a1c0c7b into opensearch-project:main Aug 29, 2024
36 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit a1c0c7b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants