Revert "Fix covereage-report workflow (#4683)" #4686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 359272e.
Description
This PR reverts a previous change that purportedly fixed the codecov-report CI check. After the PR was merged into main, I observed that the fix was not working as intended and had a false sense of fix because codecov upload works with tokenless uploads on forks.
While the change is a valid way to configure codecov/codecov-action@v4 according to the README, there is an issue with the usage of
env
inside theWandalen/[email protected]
action which is an action that automatically retries upload on failure.ref: https://github.com/opensearch-project/security/actions/runs/10561243044/job/29257710874
Initially, I made the PR because this check failed on 3 dependabot PRs:
It turns out, the issue is specific to dependabot. Dependabot does not have access to the secrets of the repo and a separate section with
Dependabot Secrets
needs to be populated.This change should be reverted and the CODECOV_TOKEN should be added to the repo as a
Dependabot Secret
Maintenance
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.