Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor security provider instantiation #4611

Conversation

dancristiancecoi
Copy link
Contributor

Backport b3e067b from #4605

Signed-off-by: Terry Quigley <[email protected]>
(cherry picked from commit d97cca8)
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (5baa3c4) to head (833ea41).

Files Patch % Lines
.../opensearch/security/OpenSearchSecurityPlugin.java 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4611      +/-   ##
==========================================
+ Coverage   65.41%   65.47%   +0.06%     
==========================================
  Files         316      316              
  Lines       22108    22116       +8     
  Branches     3572     3572              
==========================================
+ Hits        14462    14481      +19     
+ Misses       5856     5847       -9     
+ Partials     1790     1788       -2     
Files Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.63% <73.33%> (-0.11%) ⬇️

... and 5 files with indirect coverage changes

@willyborankin willyborankin merged commit 5000f16 into opensearch-project:2.x Jul 31, 2024
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants