-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin role for Query insights plugin #4006
Admin role for Query insights plugin #4006
Conversation
Signed-off-by: Chenyang Ji <[email protected]>
6e115f1
to
e7e3c4a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4006 +/- ##
==========================================
+ Coverage 65.56% 65.63% +0.06%
==========================================
Files 298 298
Lines 21246 21247 +1
Branches 3457 3457
==========================================
+ Hits 13930 13945 +15
+ Misses 5595 5582 -13
+ Partials 1721 1720 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rename the action names to follow the conventions used by the other OpenSearch plugins
Oh, this isn't a plugin... even yet, lets review this with product to see if we can get these aligned. @ansjcy Can you reach out to the product team for this?
Hi @peternied, query insights would be a new plugin to be added in 2.12, and this is for the new endpoint to be added as part of https://github.com/opensearch-project/OpenSearch/pull/11904/files#diff-8f667a33ab21bed061e1f79e106a9686526ad54be9c0be568a532459c6e89ce2R27. I have chatted with the TPM to confirm on the naming as well. |
Signed-off-by: Chenyang Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks much more consistent. Note; you'll need to update the transport actions names in OpenSearch core before this will work end to end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @ansjcy Would you please create a PR on the dashboards-plugin if we are planning to make this action 'cluster:admin/opensearch/insights/top_queries/*'
permission-able via UI.
Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 6b9ded2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport 6b9ded2 from #4006. Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Chenyang Ji <[email protected]>
Description
Adding the default role for query insights plugin
Related issues and PRs
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.