Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracer for getHttpTransports #3338

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Sep 8, 2023

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Maintenance

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
reta
reta previously approved these changes Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3338 (a1a8632) into main (72c6186) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3338   +/-   ##
=========================================
  Coverage     64.17%   64.18%           
+ Complexity     3472     3471    -1     
=========================================
  Files           263      263           
  Lines         20112    20112           
  Branches       3359     3359           
=========================================
+ Hits          12907    12908    +1     
- Misses         5526     5529    +3     
+ Partials       1679     1675    -4     
Files Changed Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.60% <ø> (ø)
...rch/security/http/SecurityHttpServerTransport.java 100.00% <ø> (ø)
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 85.11% <ø> (ø)
...curity/http/SecurityNonSslHttpServerTransport.java 100.00% <100.00%> (ø)
...ttp/netty/SecuritySSLNettyHttpServerTransport.java 84.21% <100.00%> (ø)

... and 3 files with indirect coverage changes

@RyanL1997
Copy link
Collaborator Author

Looking into the bwc failure now

@RyanL1997
Copy link
Collaborator Author

RyanL1997 commented Sep 8, 2023

After 5 times re-run on the task of plugin install for windows runner, it is still failing on the connection issue:

Run peternied/action-sleep@v1
Run Start-Sleep -s 30
Run $credentialBytes = [Text.Encoding]::ASCII.GetBytes("admin:admin")
Invoke-WebRequest: D:\a\_temp\cebbf9a0-1544-42d9-ac73-cebfa0841e9f.ps1:6
Line |
   6 |  Invoke-WebRequest -SkipCertificateCheck -Uri 'https://localhost:9200/ …
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | No connection could be made because the target machine actively refused it.

Error: Process completed with exit code 1.

So I was wondering, if this changes brought some longer setup time for windows? I may want to extend the sleep time to see what happens.

@peternied
Copy link
Member

The error logs indicate there is a bug preventing the server from coming up:

Error: 9-08T21:50:21,330][ERROR][o.o.b.Bootstrap          ] [smoketestnode] Exception
java.lang.IllegalStateException: Unsupported http.type [org.opensearch.security.http.SecurityHttpServerTransport]
	at org.opensearch.common.network.NetworkModule.getHttpServerTransportSupplier(NetworkModule.java:240) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.newHttpTransport(Node.java:1757) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.<init>(Node.java:911) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.<init>(Node.java:[400](https://github.com/opensearch-project/security/actions/runs/6126464757/job/16631275359?pr=3338#step:8:413)) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:[404](https://github.com/opensearch-project/security/actions/runs/6126464757/job/16631275359?pr=3338#step:8:417)) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:180) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:171) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) [opensearch-cli-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.Command.main(Command.java:101) [opensearch-cli-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:137) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:103) [opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
Error: 9-08T21:50:21,345][ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [smoketestnode] uncaught exception in thread [main]
org.opensearch.bootstrap.StartupException: java.lang.IllegalStateException: Unsupported http.type [org.opensearch.security.http.SecurityHttpServerTransport]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:184) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:171) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) ~[opensearch-cli-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.cli.Command.main(Command.java:101) ~[opensearch-cli-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:137) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:103) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
Caused by: java.lang.IllegalStateException: Unsupported http.type [org.opensearch.security.http.SecurityHttpServerTransport]
	at org.opensearch.common.network.NetworkModule.getHttpServerTransportSupplier(NetworkModule.java:240) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.newHttpTransport(Node.java:1757) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.<init>(Node.java:911) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.node.Node.<init>(Node.java:400) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:180) ~[opensearch-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
	... 6 more

@cwperks
Copy link
Member

cwperks commented Sep 11, 2023

This PR is blocked by the Auto increment PR: #3323

The bwc tests are failing because a cluster cannot be formed between 2.10 and 3.0.0 now that 2.11 exists.

@cwperks
Copy link
Member

cwperks commented Sep 11, 2023

@RyanL1997 You may need to add the changes from #3323 into this PR

@willyborankin
Copy link
Collaborator

i cant merge it. no permissions

@peternied
Copy link
Member

This is a case of a diamond dependency conflict. I'm going to merge these changes and then backport this changes into #3323 as @cwperks mentioned

@peternied peternied merged commit c9e109f into opensearch-project:main Sep 11, 2023
@peternied peternied added the backport 2.x backport to 2.x branch label Sep 11, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2023
Add tracer for getHttpTransports

- Related Add Tracing Instrumentation at Network and Rest layer OpenSearch#9415

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit c9e109f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied pushed a commit to peternied/security that referenced this pull request Sep 11, 2023
Add tracer for getHttpTransports

- Related Add Tracing Instrumentation at Network and Rest layer OpenSearch#9415

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit c9e109f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peternied added a commit that referenced this pull request Sep 12, 2023
- Incremented version to **2.11.0-SNAPSHOT**.
- Backport c9e109f from #3338.

---------

Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants