Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commons-lang version #3301

Conversation

willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented Sep 4, 2023

Description

Bump commons lang to 3.13

Issues Resolved

#3300

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Commons lang version is 3.13

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin force-pushed the fix-commons-lang-version branch from 542311c to 8684705 Compare September 4, 2023 18:33
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #3301 (8684705) into 2.x (d8a30d4) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3301      +/-   ##
============================================
+ Coverage     63.13%   63.16%   +0.02%     
- Complexity     3343     3346       +3     
============================================
  Files           256      256              
  Lines         19441    19441              
  Branches       3282     3282              
============================================
+ Hits          12274    12279       +5     
+ Misses         5573     5567       -6     
- Partials       1594     1595       +1     

see 3 files with indirect coverage changes

@peternied peternied reopened this Sep 5, 2023
@peternied
Copy link
Member

@willyborankin Why did close this out? Seems like we need it to ship 2.x

@cwperks
Copy link
Member

cwperks commented Sep 5, 2023

I'm just seeing this now. I think it would be better to reference the version from core's version.properties: #3306

@peternied
Copy link
Member

I'm just seeing this now. I think it would be better to reference the version from core's version.properties: #3306

Agreed

@peternied peternied closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants