[Backport 2.x] Use ExtensionsManager.lookupExtensionSettingsById when verifying exte… #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion unique id (opensearch-project#2749) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 9d758f9)
peternied
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997 and
stephen-crawford
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## 2.x #2755 +/- ##
============================================
- Coverage 61.40% 61.27% -0.13%
+ Complexity 3317 3308 -9
============================================
Files 268 268
Lines 18346 18346
Branches 3246 3246
============================================
- Hits 11265 11242 -23
- Misses 5506 5527 +21
- Partials 1575 1577 +2
|
|
@cwperks what do you think about merging this immediately to unblock CI in main? |
davidlago
approved these changes
May 10, 2023
stephen-crawford
pushed a commit
to stephen-crawford/security
that referenced
this pull request
May 16, 2023
…nsion unique id (opensearch-project#2749) (opensearch-project#2755) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 9d758f9) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use ExtensionsManager.lookupExtensionSettingsById when verifying extension unique id (#2749)
Signed-off-by: Craig Perkins [email protected]
(cherry picked from commit 9d758f9)
Issues Resolved
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.