Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Move versioning logic to the root project #208

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Nov 1, 2023

Instead of computing the OpenSearch + plugin version in the subprojects, we can do it in the root project and propagate the ext variables.

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • [x ] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Instead of computing the OpenSearch + plugin version in the subprojects,
we can do it in the root project and propagate the `ext` variables.

Signed-off-by: Michael Froh <[email protected]>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #208 (2cab625) into 2.x (f9c47fd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #208   +/-   ##
=========================================
  Coverage     83.30%   83.30%           
  Complexity      337      337           
=========================================
  Files            43       43           
  Lines          1270     1270           
  Branches        155      155           
=========================================
  Hits           1058     1058           
  Misses          134      134           
  Partials         78       78           

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@noCharger noCharger merged commit 5e330a5 into opensearch-project:2.x Nov 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants