Query Grouping Integration Tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshsidd
requested review from
ansjcy,
jainankitk and
dzane17
as code owners
|
The build will pass after the following PR is merged : https://github.com/opensearch-project/query-insights/pull/66/files |
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd
force-pushed
the
sid/query-grouping-integtest
branch
from
6fb7300 to
8c23d8e
Compare
ansjcy
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add Query Grouping Integtests Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix settings name in tests Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 90a3450) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add Query Grouping Integtests Signed-off-by: Siddhant Deshmukh <[email protected]> * Spotless apply Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix settings name in tests Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 90a3450) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 4, 2024
deshsidd
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add Query Grouping Integtests * Spotless apply * Fix settings name in tests --------- (cherry picked from commit 90a3450) Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add Query Grouping Integtests * Spotless apply * Fix settings name in tests --------- (cherry picked from commit 90a3450) Signed-off-by: Siddhant Deshmukh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration tests for #66
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
addresses opensearch-project/OpenSearch#13357
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.