-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment latency, cpu and memory histograms for query/aggregation/sort query types #30
Increment latency, cpu and memory histograms for query/aggregation/sort query types #30
Conversation
…rt types Signed-off-by: Siddhant Deshmukh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, minor comments!
...ain/java/org/opensearch/plugin/insights/core/service/categorizer/SearchQueryCategorizer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/plugin/insights/core/service/categorizer/SearchQueryCategorizer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/plugin/insights/core/service/categorizer/SearchQueryCategorizer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/SearchQueryCounters.java
Outdated
Show resolved
Hide resolved
...ava/org/opensearch/plugin/insights/core/service/categorizor/SearchQueryCategorizerTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siddhant Deshmukh <[email protected]>
Signed-off-by: Siddhant Deshmukh <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.16
# Create a new branch
git switch --create backport/backport-30-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed1ccf8884c6bd42e468d697f552e29258318fcf
# Push it to GitHub
git push --set-upstream origin backport/backport-30-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-30-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ed1ccf8884c6bd42e468d697f552e29258318fcf
# Push it to GitHub
git push --set-upstream origin backport/backport-30-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x Then, create a pull request where the |
…rt query types (opensearch-project#30) * Increment latency, cpu and memory histograms for query/aggregation/sort types Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit ed1ccf8)
…rt query types (opensearch-project#30) * Increment latency, cpu and memory histograms for query/aggregation/sort types Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit ed1ccf8)
…rt query types (#30) (#38) * Increment latency, cpu and memory histograms for query/aggregation/sort types Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit ed1ccf8)
…rt query types (#30) (#37) * Increment latency, cpu and memory histograms for query/aggregation/sort types Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit ed1ccf8)
Integrate latency and resource usage data to the query categorization data.
Description
Followup for the following, we now increment histograms for latency, cpu and memory for each query type, aggregation type and sort order.
Issues Resolved
resolves opensearch-project/OpenSearch#14588
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.