[Backport 2.x] Move query categorization changes to plugin #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Move query categorization changes to plugin Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix SearchSourceBuilder read/write test failures Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix tests Signed-off-by: Siddhant Deshmukh <[email protected]> * Fix starting and stopping query insights service Signed-off-by: Siddhant Deshmukh <[email protected]> * Unit tests for feature enable/disable and refactor logic Signed-off-by: Siddhant Deshmukh <[email protected]> --------- Signed-off-by: Siddhant Deshmukh <[email protected]> (cherry picked from commit 811f4a5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
ansjcy,
jainankitk,
deshsidd and
dzane17
as code owners
|
We need to merge this opensearch-project/OpenSearch#14762 to make the build pass before merging. |
That is merged already, we should get the build to pass now! |
jainankitk
approved these changes
Jul 17, 2024
|
Trying to rerun the builds, although might take some time before it can pick up changes from core |
deshsidd
approved these changes
Jul 18, 2024
|
Will need to wait for the new core build to be picked up as still failing with the following : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 811f4a5 from #16.