fix build error in NodeRequest class for 2.x #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansjcy
changed the title
deshsidd
approved these changes
Jul 16, 2024
Signed-off-by: Chenyang Ji <[email protected]>
ansjcy
force-pushed
the
fix-NodeRequest-build-error
branch
from
c01a74a to
96e6370
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Chenyang Ji <[email protected]> (cherry picked from commit 95ad2c7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy
pushed a commit
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 95ad2c7) Signed-off-by: Chenyang Ji <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in 2.x the build is failing with
This is because we missed one change diff in 2.x when cutting the branch in query insights repo.
in 2.x we are still using the deprecated
BaseNodeRequestwhile in 3.0 we switched toTransportRequestsince we deprecated the BaseNodeRequest.My previous related changes on 2.x in core repo: https://github.com/opensearch-project/OpenSearch/pull/12203/files#diff-933240c7b0d2df71fdafb54891e8508cff8c45efa814cd6ba3626b58dcd60ee5R126
My previous related changes on main in core repo: https://github.com/opensearch-project/OpenSearch/pull/11904/files#diff-933240c7b0d2df71fdafb54891e8508cff8c45efa814cd6ba3626b58dcd60ee5R126
Other examples in core:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.