-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run docker OS cluster with different JDK version #276
Run docker OS cluster with different JDK version #276
Conversation
Signed-off-by: Filip Drobnjakovic <[email protected]>
Signed-off-by: Filip Drobnjakovic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
============================================
- Coverage 71.54% 71.51% -0.04%
+ Complexity 2987 2985 -2
============================================
Files 380 380
Lines 18984 18984
Branches 1463 1463
============================================
- Hits 13583 13576 -7
- Misses 4805 4810 +5
- Partials 596 598 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -10,10 +10,22 @@ | |||
################################################################################ | |||
|
|||
FROM centos:7 AS prep_open_search_files | |||
ARG JDK_VER=11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? As this will automatically set to 11 from workflow logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, from the workflow point of view it doesn't do much. I left it as a default value in the case someone deploys this locally, because we use the same Dockerfile here so that docker build can be called without build args.
Look good to me overall. One minor comment. |
Thank you for taking care of this @Tjofil |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-276-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4734d6d5ba68ba41b6c62ab2cbf5ff22aa52a186
# Push it to GitHub
git push --set-upstream origin backport/backport-276-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Filip Drobnjakovic [email protected]
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Issue #162
Describe the solution you are proposing
Workflow matrix parameter is passed through gradle argument and then to Dockerfile where corresponding JDK version is downloaded and placed in the plain 'jdk' folder to reduce further parameterization and complication of Dockerfile.
Also we add conditional jvm.options hack line because of #161, once it's solved we can get rid of it.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.