Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to Log4j 2.17, incremented version #106

Closed
wants to merge 2 commits into from

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 20, 2021

Is your feature request related to a problem? Please provide an existing Issue # , or describe.

Updated to Log4j 2.17, incremented version top 1.3.0.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock requested a review from a team December 20, 2021 17:21
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #106 (7e97f77) into main (14e87db) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #106      +/-   ##
============================================
- Coverage     72.01%   71.99%   -0.02%     
  Complexity     2942     2942              
============================================
  Files           376      376              
  Lines         18723    18723              
  Branches       1432     1432              
============================================
- Hits          13483    13480       -3     
- Misses         4652     4659       +7     
+ Partials        588      584       -4     
Impacted Files Coverage Δ
.../org/opensearch/performanceanalyzer/core/Util.java 62.50% <0.00%> (-8.34%) ⬇️
...nalyzer/rca/net/handler/PublishRequestHandler.java 78.04% <0.00%> (-4.88%) ⬇️
...ensearch/performanceanalyzer/hwnet/NetworkE2E.java 77.47% <0.00%> (-1.81%) ⬇️
...nsearch/performanceanalyzer/rca/RcaController.java 80.61% <0.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e87db...7e97f77. Read the comment docs.

@jotok
Copy link
Contributor

jotok commented Dec 20, 2021

The Java CI failed with this error:

* What went wrong:
Execution failed for task ':dependencyLicenses'.
> Missing LICENSE for log4j-api-2.16.0.jar, expected in log4j-api-LICENSE.txt

We saw a similar error in #103 when updating from 2.15 to 2.16. Given that that PR was merged successfully, I will expedite this change in order to proceed with log4j patching.

@dblock dblock closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants