#963 Remove Outdated PPL Sort Syntax #994
Draft
+15
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: currantw <[email protected]>
currantw
force-pushed
the
#963_ppl_sort_syntax
branch
from
b44dad7 to
0e03dd8
Compare
YANG-DB
reviewed
Dec 16, 2024
| : (PLUS | MINUS)? sortFieldExpression | ||
| ; | ||
|
|
||
| sortFieldExpression |
There was a problem hiding this comment.
@currantw if i understand correctly - we remove the cast capability in the sort statement in favour of using the cast operator before ...
- can u plz add a few additional test examples for these use cases ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #963.
Related Issues
OpenSearch SQL issue: opensearch-project/sql#3180
Check List
Updated documentation (docs/ppl-lang/README.md)New added source code should include a copyright header--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.