Skip to content

Update aws-sigv4 to >= 0.57 (#201) #237

Update aws-sigv4 to >= 0.57 (#201)

Update aws-sigv4 to >= 0.57 (#201) #237

GitHub Actions / clippy succeeded Nov 6, 2023 in 0s

clippy

17 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 17
Note 0
Help 0

Versions

  • rustc 1.75.0-nightly (fee5518cd 2023-11-05)
  • cargo 1.75.0-nightly (65e297d1e 2023-11-03)
  • clippy 0.1.75 (fee5518 2023-11-05)

Annotations

Check warning on line 69 in yaml_test_runner/src/github.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> yaml_test_runner/src/github.rs:69:31
   |
69 |     let response = client.get(&url).send()?;
   |                               ^^^^ help: change this to: `url`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 511 in yaml_test_runner/src/generator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> yaml_test_runner/src/generator.rs:511:33
    |
511 |     let mut file = File::create(&path)?;
    |                                 ^^^^^ help: change this to: `path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 207 in yaml_test_runner/src/generator.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless use of `format!`

warning: useless use of `format!`
   --> yaml_test_runner/src/generator.rs:207:18
    |
207 |             Some(format!("it's included in skip.yml"))
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"it's included in skip.yml".to_string()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
    = note: `#[warn(clippy::useless_format)]` on by default

Check warning on line 9250 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9250:37
     |
9250 |     pub fn scripts_painless_execute<'a, 'b>(&'a self) -> ScriptsPainlessExecute<'a, 'b, ()> {
     |                                     ^^       ^^                                 ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9250 -     pub fn scripts_painless_execute<'a, 'b>(&'a self) -> ScriptsPainlessExecute<'a, 'b, ()> {
9250 +     pub fn scripts_painless_execute<'b>(&self) -> ScriptsPainlessExecute<'_, 'b, ()> {
     |

Check warning on line 9230 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9230:20
     |
9230 |     pub fn reindex<'a, 'b>(&'a self) -> Reindex<'a, 'b, ()> {
     |                    ^^       ^^                  ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9230 -     pub fn reindex<'a, 'b>(&'a self) -> Reindex<'a, 'b, ()> {
9230 +     pub fn reindex<'b>(&self) -> Reindex<'_, 'b, ()> {
     |

Check warning on line 9216 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9216:17
     |
9216 |     pub fn ping<'a, 'b>(&'a self) -> Ping<'a, 'b> {
     |                 ^^       ^^               ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9216 -     pub fn ping<'a, 'b>(&'a self) -> Ping<'a, 'b> {
9216 +     pub fn ping<'b>(&self) -> Ping<'_, 'b> {
     |

Check warning on line 9190 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9190:17
     |
9190 |     pub fn info<'a, 'b>(&'a self) -> Info<'a, 'b> {
     |                 ^^       ^^               ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9190 -     pub fn info<'a, 'b>(&'a self) -> Info<'a, 'b> {
9190 +     pub fn info<'b>(&self) -> Info<'_, 'b> {
     |

Check warning on line 9178 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9178:33
     |
9178 |     pub fn get_script_languages<'a, 'b>(&'a self) -> GetScriptLanguages<'a, 'b> {
     |                                 ^^       ^^                             ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9178 -     pub fn get_script_languages<'a, 'b>(&'a self) -> GetScriptLanguages<'a, 'b> {
9178 +     pub fn get_script_languages<'b>(&self) -> GetScriptLanguages<'_, 'b> {
     |

Check warning on line 9172 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9172:31
     |
9172 |     pub fn get_script_context<'a, 'b>(&'a self) -> GetScriptContext<'a, 'b> {
     |                               ^^       ^^                           ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9172 -     pub fn get_script_context<'a, 'b>(&'a self) -> GetScriptContext<'a, 'b> {
9172 +     pub fn get_script_context<'b>(&self) -> GetScriptContext<'_, 'b> {
     |

Check warning on line 9162 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9162:25
     |
9162 |     pub fn get_all_pits<'a, 'b>(&'a self) -> GetAllPits<'a, 'b> {
     |                         ^^       ^^                     ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9162 -     pub fn get_all_pits<'a, 'b>(&'a self) -> GetAllPits<'a, 'b> {
9162 +     pub fn get_all_pits<'b>(&self) -> GetAllPits<'_, 'b> {
     |

Check warning on line 9134 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9134:23
     |
9134 |     pub fn delete_pit<'a, 'b>(&'a self) -> DeletePit<'a, 'b, ()> {
     |                       ^^       ^^                    ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
     |
9134 -     pub fn delete_pit<'a, 'b>(&'a self) -> DeletePit<'a, 'b, ()> {
9134 +     pub fn delete_pit<'b>(&self) -> DeletePit<'_, 'b, ()> {
     |

Check warning on line 9116 in opensearch/src/root/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a

warning: the following explicit lifetimes could be elided: 'a
    --> opensearch/src/root/mod.rs:9116:28
     |
9116 |     pub fn delete_all_pits<'a, 'b>(&'a self) -> DeleteAllPits<'a, 'b> {
     |                            ^^       ^^                        ^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
     = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
     |
9116 -     pub fn delete_all_pits<'a, 'b>(&'a self) -> DeleteAllPits<'a, 'b> {
9116 +     pub fn delete_all_pits<'b>(&self) -> DeleteAllPits<'_, 'b> {
     |

Check warning on line 16 in opensearch/src/models/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple fields are never read

warning: multiple fields are never read
  --> opensearch/src/models/mod.rs:16:5
   |
15 | pub struct OpenSearchVersionInfo {
   |            --------------------- fields in this struct
16 |     distribution: String,
   |     ^^^^^^^^^^^^
17 |     number: String,
   |     ^^^^^^
18 |     build_type: String,
   |     ^^^^^^^^^^
19 |     build_hash: String,
   |     ^^^^^^^^^^
20 |     build_date: String,
   |     ^^^^^^^^^^
21 |     build_snapshot: bool,
   |     ^^^^^^^^^^^^^^
22 |     lucene_version: String,
   |     ^^^^^^^^^^^^^^
23 |     minimum_wire_compatibility_version: String,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
24 |     minimum_index_compatibility_version: String,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `OpenSearchVersionInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

Check warning on line 6 in opensearch/src/models/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `name`, `cluster_name`, `cluster_uuid`, `version`, and `tag_line` are never read

warning: fields `name`, `cluster_name`, `cluster_uuid`, `version`, and `tag_line` are never read
  --> opensearch/src/models/mod.rs:6:5
   |
5  | pub struct InfoResponse {
   |            ------------ fields in this struct
6  |     name: String,
   |     ^^^^
7  |     cluster_name: String,
   |     ^^^^^^^^^^^^
8  |     cluster_uuid: String,
   |     ^^^^^^^^^^^^
9  |     version: OpenSearchVersionInfo,
   |     ^^^^^^^
10 |     #[serde(rename = "tagline")]
11 |     tag_line: String,
   |     ^^^^^^^^
   |
   = note: `InfoResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 110 in opensearch/src/auth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
   --> opensearch/src/auth.rs:110:7
    |
110 | #[cfg(any(feature = "aws-auth"))]
    |       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "aws-auth"`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

Check warning on line 93 in opensearch/src/auth.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded sub `cfg` when there is only one condition

warning: unneeded sub `cfg` when there is only one condition
  --> opensearch/src/auth.rs:93:7
   |
93 | #[cfg(any(feature = "aws-auth"))]
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "aws-auth"`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
   = note: `#[warn(clippy::non_minimal_cfg)]` on by default

Check warning on line 44 in api_generator/src/rest_spec/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> api_generator/src/rest_spec/mod.rs:44:31
   |
44 |     let response = client.get(&url).send()?;
   |                               ^^^^ help: change this to: `url`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default