Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lint error. #875

Merged
merged 1 commit into from
Dec 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Changed
- Small refactor of AWS Signer classes for both sync and async clients ([866](https://github.com/opensearch-project/opensearch-py/pull/866))
- Small refactor to fix overwriting the module files when generating apis ([874](https://github.com/opensearch-project/opensearch-py/pull/874))
- Fixed a "type ignore" lint error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For next time, we usually don't need changelog for anything minor like this, we can add a skip-changelog label to the PR.

### Deprecated
### Removed
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion opensearchpy/_async/http_aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -386,4 +386,4 @@ async def text(self, encoding: Any = None, errors: str = "strict") -> Any:
if self._body is None:
await self.read()

return self._body.decode("utf-8", "surrogatepass") # type: ignore
return self._body.decode("utf-8", "surrogatepass")
2 changes: 1 addition & 1 deletion opensearchpy/connection/http_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,4 +298,4 @@
if self._body is None:
await self.read()

return self._body.decode("utf-8", "surrogatepass") # type: ignore
return self._body.decode("utf-8", "surrogatepass")

Check warning on line 301 in opensearchpy/connection/http_async.py

View check run for this annotation

Codecov / codecov/patch

opensearchpy/connection/http_async.py#L301

Added line #L301 was not covered by tests
Loading