Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PIT example in search.md #869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mausch
Copy link

@mausch mausch commented Dec 12, 2024

Description

Fix PIT example, it was using some old methods/APIs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mauricio Scheffer <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (ba715b9) to head (a8a43db).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   71.95%   70.37%   -1.58%     
==========================================
  Files          91      125      +34     
  Lines        8001     9290    +1289     
==========================================
+ Hits         5757     6538     +781     
- Misses       2244     2752     +508     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Want to add this as a working example to https://github.com/opensearch-project/opensearch-py/tree/main/samples? Let's make sure it runs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants