Small refactor of AWS Signer classes for both sync and async clients #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Murino <[email protected]>
Signed-off-by: Bruno Murino <[email protected]>
…ync and async clients Signed-off-by: Bruno Murino <[email protected]>
Signed-off-by: Bruno Murino <[email protected]>
Signed-off-by: Bruno Murino <[email protected]>
…ved testing on them as well Signed-off-by: Bruno Murino <[email protected]>
Signed-off-by: Bruno Murino <[email protected]>
brunomurino
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Signed-off-by: Bruno Murino <[email protected]>
Signed-off-by: Bruno Murino <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 71.95% 70.39% -1.56%
==========================================
Files 91 125 +34
Lines 8001 9290 +1289
==========================================
+ Hits 5757 6540 +783
- Misses 2244 2750 +506 ☔ View full report in Codecov by Sentry. |
|
@brunomurino if you want to do more work, I like #595 and #410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor of AWS Signer classes for both sync and async clients.
Implementing test improvements suggestion.
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.