Align pool_maxsize for different connection pool implementations. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 70.72% 70.77% +0.05%
==========================================
Files 83 83
Lines 7852 7857 +5
==========================================
+ Hits 5553 5561 +8
+ Misses 2299 2296 -3
|
dblock
force-pushed
the
pool-maxsize
branch
3 times, most recently
from
36fb442 to
4c1f049
Compare
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Signed-off-by: dblock <[email protected]>
VachaShah
reviewed
Oct 12, 2023
| use_ssl = True, | ||
| verify_certs = False, | ||
| ssl_show_warn = False, | ||
| connection_class = Urllib3HttpConnection |
There was a problem hiding this comment.
Should we make Urllib3HttpConnection default in code unless a connection_class is explicitly passed in?
There was a problem hiding this comment.
It's already default here:
opensearch-py/opensearchpy/transport.py
Line 70 in 84ac172
There was a problem hiding this comment.
Ah I missed it, so only the documentation was a bit misleading.
Signed-off-by: dblock <[email protected]>
VachaShah
approved these changes
Oct 12, 2023
|
@dblock can we add the recommendation somewhere in doc on what HTTPClient to use? with the benchmarks you have run. |
In this PR I had added "We recommend you use the default, unless your application is standardized on |
Djcarrillo6
added a commit
to Djcarrillo6/opensearch-py
that referenced
this pull request
Oct 14, 2023
Signed-off-by: Djcarrillo6 <[email protected]> Updated CHANGELOG Signed-off-by: Djcarrillo6 <[email protected]> Updated CHANGELOG & link to sample. Signed-off-by: Djcarrillo6 <[email protected]> updated changelog (opensearch-project#522) Signed-off-by: saimedhi <[email protected]> Bump version to 2.3.2 (opensearch-project#524) Signed-off-by: saimedhi <[email protected]> Fix: typos. (opensearch-project#526) * Fix: typo. Signed-off-by: dblock <[email protected]> * Fix: typo. Signed-off-by: dblock <[email protected]> * Fixed its. Signed-off-by: dblock <[email protected]> * Added Visual Code settings to .gitignore. Signed-off-by: dblock <[email protected]> * Added loop type for async client. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Modified generator to generate api deprecation warnings (opensearch-project#527) Signed-off-by: saimedhi <[email protected]> Generate cat client from API specs (opensearch-project#529) Signed-off-by: saimedhi <[email protected]> Generate cluster client from API specs (opensearch-project#530) Signed-off-by: saimedhi <[email protected]> Added new guide & sample module for using index templates. (opensearch-project#531) Added index_template guide and sample Signed-off-by: Djcarrillo6 <[email protected]> Removed EOL Python3.5 & bumped urllib3 version to patch security vulnerability (opensearch-project#533) Updated CHANGELOG with pull # Updated CHANGELOG with pull # Updated CHANGELOG removed section. Updated CHANGELOG removed section again Signed-off-by: Djcarrillo6 <[email protected]> Align pool_maxsize for different connection pool implementations. (opensearch-project#535) * Align pool_maxsize for different connection pool implementations. Signed-off-by: dblock <[email protected]> * Document connection classes and settings. Signed-off-by: dblock <[email protected]> * Undo change in async for backwards compatibility. Signed-off-by: dblock <[email protected]> * Fix: typo. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Add micro benchmarks. (opensearch-project#537) * Align pool_maxsize for different connection pool implementations. Signed-off-by: dblock <[email protected]> * Added benchmarks. Signed-off-by: dblock <[email protected]> * Multi-threaded vs. async benchmarks. Signed-off-by: dblock <[email protected]> * Set pool size to the number of threads. Signed-off-by: dblock <[email protected]> * Added sync/async benchmark. Signed-off-by: dblock <[email protected]> * Report client-side latency. Signed-off-by: dblock <[email protected]> * Various updates to benchmarks, demonstrating threading improves throughput. Signed-off-by: dblock <[email protected]> * Bench info. Signed-off-by: dblock <[email protected]> * Fixup format. Signed-off-by: dblock <[email protected]> * Undo async maxsize. Signed-off-by: dblock <[email protected]> * Moved benchmarks folder. Signed-off-by: dblock <[email protected]> * Updated documentation and project description. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]>
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…ensearch-project#535) * Align pool_maxsize for different connection pool implementations. Signed-off-by: dblock <[email protected]> * Document connection classes and settings. Signed-off-by: dblock <[email protected]> * Undo change in async for backwards compatibility. Signed-off-by: dblock <[email protected]> * Fix: typo. Signed-off-by: dblock <[email protected]> --------- Signed-off-by: dblock <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pool_maxsizefor bothUrllib3HttpConnectionandRequestsHttpConnectionpool implementations.RequestsHttpConnectionfrom the documentation when used as a default.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.