Integrated generated 'nodes' client APIs into the existing module #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal and
florianvazelle
as code owners
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 83 83
Lines 7790 7790
=======================================
Hits 5521 5521
Misses 2269 2269
|
saimedhi
force-pushed
the
merge/nodes_client
branch
from
a89c109 to
c69be17
Compare
saimedhi
force-pushed
the
merge/nodes_client
branch
2 times, most recently
from
5b9493a to
747adfd
Compare
…suring alignment with the server and maintaining backward compatibility Signed-off-by: saimedhi <[email protected]>
saimedhi
force-pushed
the
merge/nodes_client
branch
from
2928a30 to
f9d4652
Compare
Signed-off-by: Sai Medhini Reddy Maryada <[email protected]>
dblock
previously approved these changes
Oct 3, 2023
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
VachaShah
reviewed
Oct 3, 2023
| @@ -79,7 +88,6 @@ class NodesClient(NamespacedClient): | |||
| fields: Optional[Any] = ..., | |||
| groups: Optional[Any] = ..., | |||
| include_segment_file_sizes: Optional[Any] = ..., | |||
| include_unloaded_segments: Optional[Any] = ..., | |||
There was a problem hiding this comment.
Are we breaking users by removing this?
There was a problem hiding this comment.
We are not breaking users because the parameter is throwing error
{
"type": "illegal_argument_exception",
"reason": "request [/_nodes/stats] contains unrecognized parameter: [include_unloaded_segments]"
}
There was a problem hiding this comment.
Thats weird, the parameter is present in the server https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java#L136
There was a problem hiding this comment.
I'm not certain, Vacha. I'm not very familiar with the OpenSearch server code. Do we need to examine this file or action instead of the above file?
There was a problem hiding this comment.
Ah you are absolutely right! For nodes stats it does not exist.
VachaShah
approved these changes
Oct 3, 2023
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…suring alignment with the server and maintaining backward compatibility (opensearch-project#514) Signed-off-by: saimedhi <[email protected]> Signed-off-by: Sai Medhini Reddy Maryada <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrated generated 'nodes' client APIs into the existing module, ensuring alignment with the server and maintaining backward compatibility
Issues Resolved
Related to #477
Testing the "include_unloaded_segments" parameter in the "stats" API resulted in an error indicating that the parameter is unrecognized (Implies generated "stats" API is correct)
get https://localhost:9200/_nodes/stats?include_unloaded_segments=true{
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "request [/_nodes/stats] contains unrecognized parameter: [include_unloaded_segments]"
}
],
"type": "illegal_argument_exception",
"reason": "request [/_nodes/stats] contains unrecognized parameter: [include_unloaded_segments]"
},
"status": 400
}
Before giving your approval, kindly double-check.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.