Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested temporary workaround for running integTests on non Linux platforms #21

Conversation

AmiStrn
Copy link
Contributor

@AmiStrn AmiStrn commented May 11, 2021

Description

Suggesting a workaround for users to be able to test their plugins until the core issue is resolved.

Issues Resolved

This suggestion is related to opensearch-project/OpenSearch#600

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ported for builds on linux platform. However, I would like to suggest this temporary workaround until issue #600 is officially fixed.

Signed-off-by: AmiStrn <[email protected]>
@dblock
Copy link
Member

dblock commented May 11, 2021

@AmiStrn are we doing this in any of the plugins? Maybe we should be more prescriptive, remove the parenthesis and link an issue?

@AmiStrn
Copy link
Contributor Author

AmiStrn commented May 12, 2021

@dblock I agree this should be more prescriptive. I'll make a change to the text and open an issue in this repo regarding the Linux limitation.
This suggestion was successful in fixing an example plugin of mine. I will update this PR after I try this on a plugin from the opensearch repo so the solution is more concrete.

@AmiStrn
Copy link
Contributor Author

AmiStrn commented Jun 3, 2021

This PR is related to #40

@dblock dblock merged commit c4e3c96 into opensearch-project:main Jun 3, 2021
@dblock
Copy link
Member

dblock commented Jun 3, 2021

Thanks, I merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants