[Backport 1.x] feat(): add support for DateOnly and TimeOnly #680 (#734) #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#734) * feat(): add .net6 and .net8 to core project and get it to compile opensearch-project#680 Signed-off-by: Joe Feser <[email protected]> * feat(): add support for DateOnly and TimeOnly from .net 6 opensearch-project#680 Signed-off-by: Joe Feser <[email protected]> * PR Comments Signed-off-by: Joe Feser <[email protected]> * PR Comments Signed-off-by: Joe Feser <[email protected]> * modified the added section of changelog.md Signed-off-by: Joe Feser <[email protected]> * Fix compilation/indentation error Signed-off-by: Thomas Farr <[email protected]> * Fix code conventions unit test Signed-off-by: Thomas Farr <[email protected]> * Fix remaining `#if`s Signed-off-by: Thomas Farr <[email protected]> * Fix changelog ordering Signed-off-by: Thomas Farr <[email protected]> * Fix CI errors Signed-off-by: Thomas Farr <[email protected]> --------- Signed-off-by: Joe Feser <[email protected]> Signed-off-by: Thomas Farr <[email protected]> Co-authored-by: Thomas Farr <[email protected]> (cherry picked from commit f3bae74)
Xtansia
requested review from
anirudha,
dblock,
joshuali925,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
dblock
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #734 via f3bae74
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.