feat: #87 implemented rest endpoint to make stats available #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable Signed-off-by: Johannes Peter <[email protected]>
Signed-off-by: Johannes Peter <[email protected]>
JohannesDaniel
requested review from
gsingers,
macohen and
sstults
as code owners
ylwu-amzn
reviewed
Dec 17, 2024
| @@ -75,7 +76,7 @@ public String getLtrStoreHealthStatus(String storeName) { | |||
| clusterService.state().getRoutingTable().index(storeName) | |||
| ); | |||
|
|
|||
| return indexHealth.getStatus().name().toLowerCase(); | |||
| return indexHealth.getStatus().name().toLowerCase(Locale.ROOT); | |||
There was a problem hiding this comment.
Not for this line.
Why do we use default locale here https://github.com/opensearch-project/opensearch-learning-to-rank-base/blob/main/src/main/java/com/o19s/es/termstat/TermStatQueryBuilder.java#L154-L155
AggrType aggrType = AggrType.valueOf(aggr.toUpperCase(Locale.getDefault()));
AggrType posAggrType = AggrType.valueOf(pos_aggr.toUpperCase(Locale.getDefault()));
rithin-pullela-aws
approved these changes
Dec 17, 2024
Signed-off-by: Johannes Peter <[email protected]>
JohannesDaniel
commented
Dec 18, 2024
| @@ -75,7 +76,7 @@ public String getLtrStoreHealthStatus(String storeName) { | |||
| clusterService.state().getRoutingTable().index(storeName) | |||
| ); | |||
|
|
|||
| return indexHealth.getStatus().name().toLowerCase(); | |||
| return indexHealth.getStatus().name().toLowerCase(Locale.getDefault()); | |||
| } | |||
There was a problem hiding this comment.
Default as this is displayed
JohannesDaniel
commented
Dec 18, 2024
| AggrType aggrType = AggrType.valueOf(aggr.toUpperCase(Locale.getDefault())); | ||
| AggrType posAggrType = AggrType.valueOf(pos_aggr.toUpperCase(Locale.getDefault())); | ||
| AggrType aggrType = AggrType.valueOf(aggr.toUpperCase(Locale.ROOT)); | ||
| AggrType posAggrType = AggrType.valueOf(pos_aggr.toUpperCase(Locale.ROOT)); | ||
|
|
There was a problem hiding this comment.
Root as this is used for logic
sstults
approved these changes
Dec 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of now, LTRStats are collected, but not accessible via a REST endpoint. The feature is expected to return LTRStats as a map for URL path admin/ltr/stats.
Issues Resolved
#87
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.