2.10 #24
Closed
2.10 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re and a TODO regarding the Strings class Signed-off-by: Mark Cohen <[email protected]>
… yamlRestTest according to spec. integTests don't work yet so running with the following vars works -Dopensearch.version=2.7.0 -Dskip.integtests=true -Djava.security.manager=allow -Dbuild.snapshot=false buid.snapshot runs the yamlRestTest successfully. -Djava.security.manager=allow allows the deprecated SecurityManager to do it's work also updated StoredFeatureParserTests.writeAsNonFormattedString to require MediaType as per opensearch-project/OpenSearch@f9eb9bf Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
' as a branch to trigger when a tag is pushed Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
… opensearch version on command line instead of in gradle.properties Signed-off-by: Mark Cohen <[email protected]>
…is too general by subbing the semantic-ish versioning regex with a .*, but the build succeeded... Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mohammad Hasnain Mohsin Rajan <[email protected]>
fix: revert build.gradle sourceSets changes
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
' as a branch to trigger when a tag is pushed Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
… opensearch version on command line instead of in gradle.properties Signed-off-by: Mark Cohen <[email protected]>
…is too general by subbing the semantic-ish versioning regex with a .*, but the build succeeded... Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mohammad Hasnain Mohsin Rajan <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
… docker hub doesn't work right now Signed-off-by: Mark Cohen <[email protected]>
…ToRankPluginIT.java to look for 'ltr' in the response Signed-off-by: Mark Cohen <[email protected]>
…ue to reorganization of code in core Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…, but there are integ tests that need to be fixed Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
…ct)" Signed-off-by: Mikhail Khludnev <[email protected]>
2.10 fix double start
|
I had a look at the diff and looked for similar changes we had made for ml-commons. Looks like they're all there (MediaType, XContentParser, etc). |
…name (context: Object)" honoring XContent/Object/Fragment markers. In doubts. Signed-off-by: Mikhail Khludnev <[email protected]>
Thanks @austintlee. @mkhludnev managed to find that some of the tests pass if you override ToXContent.isFragment() and return true. I found that some of them fail so there's more digging to do on this one. |
StoredFeatureParserTests.testToXContent() does what StoredFeatureSetParserTests do. Signed-off-by: Mikhail Khludnev <[email protected]>
another attempt to fix ToXContent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates the build to use OpenSearch 2.10, but fails due to refactoring needed.
Issues Resolved
N.A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.