Fix typo cause it will always trigger JSON11 parse

[Hailong-am]

Description

Fix typo cause it will always trigger JSON11 parse.

if the json string has number in it, numeralsAreNumbers will always be true.

(val < Number.MAX_SAFE_INTEGER || val > Number.MAX_SAFE_INTEGER)

should changed to (val < Number.MIN_SAFE_INTEGER || val > Number.MAX_SAFE_INTEGER)

opensearch-js/lib/Serializer.js

Lines 101 to 107 in 9288450

	if (
	numeralsAreNumbers &&
	typeof val === 'number' &&
	(val < Number.MAX_SAFE_INTEGER || val > Number.MAX_SAFE_INTEGER)
	) {
	numeralsAreNumbers = false;
	}

then it will always trigger JSON11 parse

opensearch-js/lib/Serializer.js

Lines 128 to 137 in 9288450

	if (shouldHandleLongNumerals && !numeralsAreNumbers) {
	try {
	const temp = JSON11.parse(json, null, { withLongNumerals: true });
	if (temp) {
	object = temp;
	}
	} catch (ex) {
	// Do nothing: sjson.parse succeeded but JSON11.parse failed; return the sjson.parse result
	}
	}

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Check List

• New functionality includes testing.
  • All tests pass
• Linter check was successfull - yarn run lint doesn't show any errors
• Commits are signed per the DCO using --signoff
• Changelog was updated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

Thanks, could you please add a test?

[AMoo-Miki]

Thanks, could you please add a test?

Since we have positive tests, we should add negative tests.

[Hailong-am]

Thanks, could you please add a test?

Since we have positive tests, we should add negative tests.

Thanks, a negative tests added. @dblock @AMoo-Miki

[AMoo-Miki]

OSD needs this in 2.x. It would be great if we had a release for it too.

[nhtruong]

I'll cut a release today

[nhtruong]

@AMoo-Miki https://www.npmjs.com/package/@opensearch-project/opensearch/v/2.13.0