[Generator] Rendering string constants and anyOf with complex members #887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issues in #886.
1. Added ability to render string constants:
To add more info for each member of the ExpandWildcard enum, we have converted its schema into an
oneOf
object where each member is a string constant. This changes causes the generator to create:type ExpandWildcard = 'string' | 'string' | 'string' | 'string' | 'string'
instead of
type ExpandWildcard = 'all' | 'closed' | 'hidden' | 'none' | 'open'
we're adding another guard to handle
const
for the renderer.2. Added ability to render
anyOf
objects where members can be anonymous objects:The
InlineScript
is now ananyOf
object where a member is a string, and another is a complex anonymous object, previously the generator will do:which is not a valid type definition. The changes in render_anyOf and render_allOf functions will render
3. All type definitions are now
type
instead of a mix oftype
andinterface
Previously the generator would generate
interface X
whenever possible and would generatetype X =
when not. The reason? Precedence. So we ended up with a mix oftype
andinterface
declarations. These changes [1], [2], [3], simplifies the rendering logic to always rendertype
, which is also a lot more flexible (which enables change No.2 above) and better mirror JSON Schema'sallOf
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.