Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing items to the response body in guides/bulk.md #712

Closed
wants to merge 1 commit into from
Closed

Add missing items to the response body in guides/bulk.md #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions guides/bulk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ client.bulk({
{ create: { _id: 2, data: { title: 'Beauty and the Beast 4', year: 2049 } } } // document already exists error
]
}).then((response) => {
response.body.forEach((item) => {
response.body.items.forEach((item) => {
Copy link
Author

@ap-h ap-h Feb 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible items is undefined or null? According to the types it is not.

const createStatus = item.create && item.create.status;
if (createStatus && !createStatus.toString().match(/2\d{2}/)) {
console.log(item.create.error.reason);
Expand All @@ -163,4 +163,4 @@ To clean up the resources created in this guide, delete the `movies` and `books`

```javascript
client.indices.delete({ index: [movies, books] });
```
```
Loading