Added Security Namespace #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
force-pushed
the
security_namespace
branch
from
383c77a to
a110fb8
Compare
nhtruong
requested review from
ananzh,
kavilla,
seanneumann,
dblock,
VachaShah,
harshavamsi and
timursaurus
as code owners
nhtruong
force-pushed
the
security_namespace
branch
from
a110fb8 to
035fcac
Compare
|
@VachaShah I've added Tests and also added type definitions for all functions added. |
VachaShah
reviewed
Sep 21, 2023
There was a problem hiding this comment.
This is great @nhtruong! Just a minor comment.
Also, can we add the APIs in https://github.com/opensearch-project/opensearch-js/tree/main/guides and mention them in the USER_GUIDE. You can do it in the next PR.
Turned that into a good-first-issue :D #615 |
Signed-off-by: Theo Truong <[email protected]>
nhtruong
force-pushed
the
security_namespace
branch
from
a54d6de to
1037df4
Compare
VachaShah
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.