Fixed path component filter (#921)

* Fixed path component filter JS considers `''` to be false. Updating the filter to include blank strings. Signed-off-by: Theo Truong <[email protected]> * # make sure that '' in param in considered null as well Signed-off-by: Theo Truong <[email protected]> --------- Signed-off-by: Theo Truong <[email protected]>
opensearch-project · Nov 18, 2024 · 55fd7d1 · 55fd7d1
1 parent ba69002
commit 55fd7d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/api/utils.js b/api/utils.js
@@ -35,7 +35,7 @@ const kConfigErr = Symbol('configuration error');
 function noop() {}
 
 function parsePathParam(param) {
-  if (param == null) return null;
+  if (param == null || param === '') return null;
   return encodeURIComponent(param);
 }
 

diff --git a/api_generator/src/spec_parser/ApiPath.ts b/api_generator/src/spec_parser/ApiPath.ts
@@ -62,13 +62,13 @@ export default class ApiPath {
       }).join(' + ')
   }
 
-  // turn ['one', a, b, 'two/three', c] into `['/one', a, b, 'two/three', c].filter(c => c).join('/')`
-  // turn [a, b, 'one', c] into `['', a, b, 'one', c].filter(c => c).join('/')`
+  // turn ['one', a, b, 'two/three', c] into `['/one', a, b, 'two/three', c].filter(c => c != null).join('/')`
+  // turn [a, b, 'one', c] into `['', a, b, 'one', c].filter(c => c != null).join('/')`
   #build_optional (): string {
     const components = _.clone(this.components)
     if (components[0].startsWith("'")) components[0] = `'/${components[0].slice(1)}`
     else components.unshift("''")
-    return `[${components.join(', ')}].filter(c => c).join('/')`
+    return `[${components.join(', ')}].filter(c => c != null).join('/')`
   }
 
   // turn '/one/{a}/{b}/two/three/{c}' into ['one', a, b, 'two/three', c]