Removed required index for Hit.java #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For InnerHits, since the index and id is assumed to be the same as parent, they were not included in the InnerHit object, but when converting it into a Hit object in the java sdk, it would throw an exception, saying index is required. Removed it, and also added unit tests.
jvan1997
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
For InnerHits, since the index and id is assumed to be the same as parent, they were not included in the InnerHit object, but when converting it into a Hit object in the java sdk, it would throw an exception, saying index is required. Removed it, and also added unit tests. Signed-off-by: jvan1997 <[email protected]>
…nsearch-project#828) * Bump com.diffplug.spotless from 6.24.0 to 6.25.0 in /java-client Bumps com.diffplug.spotless from 6.24.0 to 6.25.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Signed-off-by: jvan1997 <[email protected]>
For InnerHits, since the index and id is assumed to be the same as parent, they were not included in the InnerHit object, but when converting it into a Hit object in the java sdk, it would throw an exception, saying index is required. Removed it, and also added unit tests. Signed-off-by: jvan1997 <[email protected]>
Sunhick
reviewed
Feb 7, 2024
| @@ -107,7 +107,7 @@ public class Hit<TDocument> implements JsonpSerializable { | |||
|
|
|||
| private Hit(Builder<TDocument> builder) { | |||
|
|
|||
| this.index = ApiTypeHelper.requireNonNull(builder.index, this, "index"); | |||
| this.index = builder.index; | |||
There was a problem hiding this comment.
How do you ensure that this is only for a inner hit ? And outer hits should enforce requireNonNull.
There was a problem hiding this comment.
I do think this is a good call out; The problem is that the the InnerHit is in a List in HitsMetadata, which is then in the InnerHitsResult.
So unless there is a file made explicitly to represent an InnerHit (which I think is a valid path), the other option would be to re-populate the Index and the Id to the InnerHits as well, even if they match the parent, or a third option to create a flag that allows a hit to know whether it is an InnerHit or main Hit.
Sunhick
reviewed
Feb 7, 2024
| import org.opensearch.client.json.JsonpMapper; | ||
| import org.opensearch.client.json.jsonb.JsonbJsonpMapper; | ||
|
|
||
| public class InnerHitsResultTest { |
There was a problem hiding this comment.
Do we have unit tests for outer hits with nullable ? Should be allowed or not allowed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For InnerHits, since the index and id is assumed to be the same as parent, they were not included in the InnerHit object, but when converting it into a Hit object in the java sdk, it would throw an exception, saying index is required. Removed it, and also added unit tests.
Description
Describe what this change achieves.
Change removes the required field for index in the Hit.java
Issues Resolved
Closes #825
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.