Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] Restore support for Java 8 (#767) #777

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[Backport] [2.x] Restore support for Java 8 (#767) #777

merged 2 commits into from
Jan 2, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 20, 2023

Backport of #767 to 2.x

@reta
Restore support for Java 8 (opensearch-project#767)
3047d50 
* Restore support for Java 8

Signed-off-by: Andriy Redko <[email protected]>

* Address code review comments (update compatibility)

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit ff5e0a2)
@reta reta force-pushed the backport/backport-767-to-2.x branch from 7f3a4a8 to eea8731 Compare December 21, 2023 00:59
dblock
dblock approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to merge this until 2.12 is released?

@reta
Copy link
Collaborator Author

reta commented Dec 21, 2023

Any reason not to merge this until 2.12 is released?

Thanks @dblock, only one reason - we could not make 2.x releases till 2.12.0 (since we cannot make a release with SNAPSHOT dependencies).

@dblock
Copy link
Member

dblock commented Dec 21, 2023

Any reason not to merge this until 2.12 is released?

Thanks @dblock, only one reason - we could not make 2.x releases till 2.12.0 (since we cannot make a release with SNAPSHOT dependencies).

Let's hold until then? We may need a security patch or an earlier release with other features.

This was referenced Dec 26, 2023
Merged
Merged
@reta reta force-pushed the backport/backport-767-to-2.x branch from eea8731 to 7864bde Compare January 2, 2024 15:29
@dblock dblock merged commit 081a17e into opensearch-project:2.x Jan 2, 2024
38 checks passed
@dblock
Copy link
Member

dblock commented Jan 2, 2024

@reta 🚢 ? Let's make a release?

@reta
Copy link
Collaborator Author

reta commented Jan 2, 2024

@reta 🚢 ? Let's make a release?

@dblock I think we agreed to hold it back till 2.12.0 (as per #777 (comment) and #777 (comment))?

@dblock
Copy link
Member

dblock commented Jan 2, 2024 •
edited
Loading

@reta 🚢 ? Let's make a release?

@dblock I think we agreed to hold it back till 2.12.0 (as per #777 (comment) and #777 (comment))?

Ah right! I already forgot what happened last year. My bad for merging it then :( Let's leave it as is merged, the 2.12 release begins Jan 9.

@dblock dblock mentioned this pull request Jan 3, 2024
Closed
dblock added a commit that referenced this pull request Jan 3, 2024
@dblock
Revert "[Backport] [2.x] Restore support for Java 8 (#767) (#777)"
cb4e79b 
This reverts commit 081a17e.
@dblock dblock mentioned this pull request Jan 3, 2024
Closed
reta added a commit to reta/opensearch-java that referenced this pull request Jan 3, 2024
@reta
Revert "[Backport] [2.x] Restore support for Java 8 (opensearch-proje…
876fd31 
…ct#767) (opensearch-project#777)"

This reverts commit 081a17e.

Signed-off-by: Andriy Redko <[email protected]>
reta added a commit to reta/opensearch-java that referenced this pull request Jan 3, 2024
@reta
Revert "[Backport] [2.x] Restore support for Java 8 (opensearch-proje…
cf0b348 
…ct#767) (opensearch-project#777)"

This reverts commit 081a17e.

Signed-off-by: Andriy Redko <[email protected]>
@reta reta mentioned this pull request Jan 3, 2024
Merged
dblock pushed a commit that referenced this pull request Jan 3, 2024
@reta
Revert "[Backport] [2.x] Restore support for Java 8 (#767) (#777)" (#800
339c16c 
)

This reverts commit 081a17e.

Signed-off-by: Andriy Redko <[email protected]>
@reta reta mentioned this pull request Jan 3, 2024
Merged
reta added a commit to reta/opensearch-java that referenced this pull request Jan 8, 2024
@reta
Revert "[Backport] [2.x] Restore support for Java 8 (opensearch-proje…
b212db9 
…ct#767) (opensearch-project#777)"

This reverts commit 081a17e.

Signed-off-by: Andriy Redko <[email protected]>
@ls-urs-keller ls-urs-keller mentioned this pull request Jan 19, 2024
Closed
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reta @dblock