Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 744 #750

Closed
wants to merge 5 commits into from
Closed

Bug 744 #750

wants to merge 5 commits into from
+164 −2

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 29, 2023

Description

This is #748 so we don't lose it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@fs-chris
Added scriptedUpsert option to UpdateOperation (opensearch-project#744)
0e7929f 
Signed-off-by: Christian Winkler <[email protected]>
@fs-chris
Added detectNoop option to UpdateOperation (opensearch-project#744)
ef3720c 
Signed-off-by: Christian Winkler <[email protected]>
@fs-chris
updated changelog
824eced 
Signed-off-by: Christian Winkler <[email protected]>
@fs-chris
Added tests
39184fa 
Signed-off-by: Christian Winkler <[email protected]
Signed-off-by: Christian Winkler <[email protected]>
@fs-chris
Running spotlessApply
d06be14 
Signed-off-by: Christian Winkler <[email protected]
Signed-off-by: Christian Winkler <[email protected]>
@dblock dblock mentioned this pull request Nov 29, 2023
Merged
@dblock
Copy link
Member Author

dblock commented Dec 4, 2023

@fs-chris Is there more to this than what's here? Code LGTM.

@fs-chris
Copy link
Contributor

fs-chris commented Dec 5, 2023

@fs-chris Is there more to this than what's here? Code LGTM.

That's all I did.

@dblock
Copy link
Member Author

dblock commented Dec 6, 2023

Thanks. Someone please make this PR onto main and a backport on 2.x.

@fs-chris
Copy link
Contributor

fs-chris commented Feb 5, 2024

Any chance to get this into 2.x shortly?
If not, I'll once more have to revert our project back to the old REST high-level client since we need the scripted-upsert option.

@dblock
Copy link
Member Author

dblock commented Feb 6, 2024

@fs-chris Can you please make this PR into main?

@fs-chris fs-chris mentioned this pull request Feb 20, 2024
Merged
@fs-chris
Copy link
Contributor

@fs-chris Can you please make this PR into main?

I didn't know how to jump onto this PR.
Created #856

@VachaShah
Copy link
Collaborator

This is done via #856

@VachaShah VachaShah closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta Awaiting requested review from reta reta will be requested when the pull request is marked ready for review reta is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar will be requested when the pull request is marked ready for review Bukhtawar is a code owner

@madhusudhankonda madhusudhankonda Awaiting requested review from madhusudhankonda madhusudhankonda will be requested when the pull request is marked ready for review madhusudhankonda is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli will be requested when the pull request is marked ready for review saratvemulapalli is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah will be requested when the pull request is marked ready for review VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblock @fs-chris @VachaShah