Add script fields support for multi search request #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
Signed-off-by: Vacha Shah <[email protected]>
|
I get |
AFAIK it seems to be request serialization issue, notice |
Oops, my bad sorry, this is |
reta
reviewed
Sep 22, 2023
| Map<String, ScriptField> scriptFields = new HashMap<>(); | ||
| scriptFields.put("test1", new ScriptField.Builder().script(Script.of(s -> s.inline(new InlineScript.Builder() | ||
| .lang("painless") | ||
| .source("ctx._source.quantity += params.inc") |
There was a problem hiding this comment.
@VachaShah that should make it (apologies for the wrong hint before):
Suggested change
| .source("ctx._source.quantity += params.inc") | |
| .source("doc['quantity'].value + params.inc") |
There was a problem hiding this comment.
Thank you @reta, that works!!
Signed-off-by: Vacha Shah <[email protected]>
VachaShah
requested review from
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda and
saratvemulapalli
as code owners
reta
reviewed
Sep 25, 2023
java-client/src/main/java/org/opensearch/client/opensearch/core/msearch/MultisearchBody.java
Show resolved
Hide resolved
reta
approved these changes
Sep 29, 2023
dblock
approved these changes
Sep 30, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-632-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c97111f53f8d91f2550d8232aaf82daf8d7f384
# Push it to GitHub
git push --set-upstream origin backport/backport-632-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
VachaShah
added a commit
to VachaShah/opensearch-java
that referenced
this pull request
Oct 3, 2023
…t#632) * Adding script_fields support for mseearch request with tests Signed-off-by: Vacha Shah <[email protected]> * Fixing logger in Search sample Signed-off-by: Vacha Shah <[email protected]> * Fixing build Signed-off-by: Vacha Shah <[email protected]> * Fixing tests Signed-off-by: Vacha Shah <[email protected]> --------- Signed-off-by: Vacha Shah <[email protected]>
VachaShah
added a commit
that referenced
this pull request
Oct 3, 2023
* Adding script_fields support for mseearch request with tests * Fixing logger in Search sample * Fixing build * Fixing tests --------- Signed-off-by: Vacha Shah <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding script_fields support to multi search requests.
Issues Resolved
Resolves #617
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.