Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate remaining analysis types #1289

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Nov 12, 2024

Description

Generate remaining analysis types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@reta reta Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have versioned + published OpenAPI spec now, any reasons to keep this clone?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still having to make a decent number of spec changes in tandem with generating to make sure things are correct and matching up, so having the local copy makes that simpler for the time being.

I do plan on switching it over once all the code that should be generated is generated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have created #1290

@Xtansia Xtansia merged commit 3955240 into opensearch-project:main Nov 12, 2024
66 checks passed
@Xtansia Xtansia deleted the feat/code-gen/analysis branch November 12, 2024 23:53
Xtansia added a commit to Xtansia/opensearch-java that referenced this pull request Nov 20, 2024
* Generate Tokenizer variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate Analyzer variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate CharFilter variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate Normalizer variants

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 3955240)
Xtansia added a commit that referenced this pull request Nov 21, 2024
* Bump org.junit:junit-bom from 5.11.2 to 5.11.3 (#1272)

* Bump org.junit:junit-bom from 5.11.2 to 5.11.3

Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.2 to 5.11.3.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.11.2...r5.11.3)

Signed-off-by: Thomas Farr <[email protected]>

---
updated-dependencies:
- dependency-name: org.junit:junit-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update changelog

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
(cherry picked from commit 38e1b9c)

* Generate remaining analysis types (#1289)

* Generate Tokenizer variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate Analyzer variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate CharFilter variants

Signed-off-by: Thomas Farr <[email protected]>

* Generate Normalizer variants

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 3955240)

* Generate Property variants (#1291)

* Generate Property variants

Signed-off-by: Thomas Farr <[email protected]>

* Handle default Property variant

Signed-off-by: Thomas Farr <[email protected]>

* spotless

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit 5dbe61e)

* Generate basic index template operations  (#1293)

* Generate basic index template operations

Generate indices.get_index_template

Signed-off-by: Thomas Farr <[email protected]>

Generate indices.put_index_template

Signed-off-by: Thomas Farr <[email protected]>

Generate indices.exists_index_template

Signed-off-by: Thomas Farr <[email protected]>

Generate indices.delete_index_template

Signed-off-by: Thomas Farr <[email protected]>

Generate indices.simulate_index_template

Signed-off-by: Thomas Farr <[email protected]>

* Allow deserializing path params from JSON

Signed-off-by: Thomas Farr <[email protected]>

* Fix compile

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
(cherry picked from commit c7103d8)

* Re-generate client code using latest OpenSearch API specification (2024-11-18) (#1236)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit e1f8e9f)

* Generate IcuCollationKeywordProperty

Signed-off-by: Thomas Farr <[email protected]>

---------

Signed-off-by: Thomas Farr <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants