Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Discover Saved Search Tests #1585

Closed

Conversation

LDrago27
Copy link
Contributor

@LDrago27 LDrago27 commented Oct 4, 2024

Description

Update the Discover Saved Search tests based on fixes raised as Part of opensearch-project/OpenSearch-Dashboards#8306. The screenshot below is where we run the above tests on the fixed PR.
image

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@LDrago27 LDrago27 force-pushed the updateDiscoverTest branch from e414dc4 to b7a808a Compare October 7, 2024 20:28
Copy link
Collaborator

@yujin-emma yujin-emma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LDrago27
Copy link
Contributor Author

This is not required. This has been covered in

@LDrago27 LDrago27 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants