-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increased timeout thresholds for alerting cypress tests to reduce flakiness when running on slow domains. #1093
Increased timeout thresholds for alerting cypress tests to reduce flakiness when running on slow domains. #1093
Conversation
…kiness when running on slow domains. Signed-off-by: AWSHurneyt <[email protected]>
I don't have permissions to add labels. Could someone add the |
Signed-off-by: AWSHurneyt <[email protected]>
|
LGTM and approved, but could you please elaborate more on why need to increase the timeout to 60000? |
60000 is mostly arbitrary; but I did notice that it would sometimes take a very long time (more than 30 seconds) for pages to refresh during the cypress tests. That was causing tests to fail. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1093-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3588e1e62af2bcadc8d0a3e57e180b995e3fc41
# Push it to GitHub
git push --set-upstream origin backport/backport-1093-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.12 2.12
# Navigate to the new working tree
cd .worktrees/backport-2.12
# Create a new branch
git switch --create backport/backport-1093-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3588e1e62af2bcadc8d0a3e57e180b995e3fc41
# Push it to GitHub
git push --set-upstream origin backport/backport-1093-to-2.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.12 Then, create a pull request where the |
@AWSHurneyt both backport 2.x and 2.12 are failed, you might need do manual backport. |
@Hailong-am Created the following PRs to manually backport. |
Description
Increased timeout thresholds for alerting cypress tests to reduce flakiness when running on slow domains.
Issues Resolved
opensearch-project/alerting-dashboards-plugin#867
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.