Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased timeout thresholds for alerting cypress tests to reduce flakiness when running on slow domains. #1093

Merged

Conversation

AWSHurneyt
Copy link
Contributor

Description

Increased timeout thresholds for alerting cypress tests to reduce flakiness when running on slow domains.

Issues Resolved

opensearch-project/alerting-dashboards-plugin#867

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…kiness when running on slow domains.

Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt
Copy link
Contributor Author

I don't have permissions to add labels. Could someone add the backport 2.x, and backport 2.12 labels?

Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt
Copy link
Contributor Author

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/alerting-dashboards-plugin/      03:59        3        3        -        -        - │
  │    acknowledge_alerts_modal_spec.js                                                            │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      05:10        5        5        -        -        - │
  │    alert_spec.js                                                                               │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      03:31        2        2        -        -        - │
  │    alerts_dashboard_flyout_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      10:47        4        4        -        -        - │
  │    bucket_level_monitor_spec.js                                                                │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      07:31        6        6        -        -        - │
  │    cluster_metrics_monitor_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      03:04        2        2        -        -        - │
  │    composite_level_monitor_spec.js                                                             │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      10:57        5        5        -        -        - │
  │    document_level_monitor_spec.js                                                              │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      01:22        1        1        -        -        - │
  │    monitors_dashboard_spec.js                                                                  │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  plugins/alerting-dashboards-plugin/      17:00        8        8        -        -        - │
  │    query_level_monitor_spec.js                                                                 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘

@AWSHurneyt AWSHurneyt marked this pull request as ready for review February 17, 2024 01:40
@SuZhou-Joe
Copy link
Member

LGTM and approved, but could you please elaborate more on why need to increase the timeout to 60000?

@AWSHurneyt
Copy link
Contributor Author

LGTM and approved, but could you please elaborate more on why need to increase the timeout to 60000?

60000 is mostly arbitrary; but I did notice that it would sometimes take a very long time (more than 30 seconds) for pages to refresh during the cypress tests. That was causing tests to fail.

@xluo-aws xluo-aws merged commit d3588e1 into opensearch-project:main Feb 17, 2024
40 of 41 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1093-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3588e1e62af2bcadc8d0a3e57e180b995e3fc41
# Push it to GitHub
git push --set-upstream origin backport/backport-1093-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1093-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.12 2.12
# Navigate to the new working tree
cd .worktrees/backport-2.12
# Create a new branch
git switch --create backport/backport-1093-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3588e1e62af2bcadc8d0a3e57e180b995e3fc41
# Push it to GitHub
git push --set-upstream origin backport/backport-1093-to-2.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-1093-to-2.12.

@Hailong-am
Copy link
Collaborator

@AWSHurneyt both backport 2.x and 2.12 are failed, you might need do manual backport.

@AWSHurneyt
Copy link
Contributor Author

@AWSHurneyt both backport 2.x and 2.12 are failed, you might need do manual backport.

@Hailong-am Created the following PRs to manually backport.
#1114
#1115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants