Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nighlty run for remote-store and 1-replica cluster config #3677

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

rishabh6788
Copy link
Collaborator

@rishabh6788 rishabh6788 commented Jun 26, 2023

Description

This PR:

  1. Adds support to run nightly benchmarks on clusters with 2-replica and 1-replica separately.
  2. Adds support to run nightly-benchmark for Remote Store feature set to be released in 2.9.

Issues Resolved

opensearch-project/OpenSearch#8087

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3677 (581056b) into main (daeeee9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3677   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         182      182           
  Lines        5408     5408           
=======================================
  Hits         4950     4950           
  Misses        458      458           

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, tho this can definitely be reduced in length with a env var in Jenkinsfile.

Suggest improvement later.

Thanks.

@ankitkala
Copy link
Member

@rishabh6788 Can you confirm that SegRep experimental flag opensearch.experimental.feature.segment_replication_experimental.enabled is enabled for this run? Segment Replication integration with remote store is behind this flag.

@rishabh6788
Copy link
Collaborator Author

These are the settings added to nightly remote-store runs.

opensearch.experimental.feature.remote_store.enabled:true 
cluster.remote_store.enabled:true 
opensearch.experimental.feature.segment_replication_experimental.enabled:true. 
cluster.indices.replication.strategy:SEGMENT

@ankitkala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants