Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new release notes scripts for consolidated release notes #3601

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jun 5, 2023

Description

Add new release notes scripts for consolidated release notes

Issues Resolved

#3434

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon force-pushed the release-notes-scripts branch from a2dc60e to d1697c5 Compare June 5, 2023 23:46
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #3601 (a2dc60e) into main (c684bc1) will not change coverage.
The diff coverage is n/a.

❗ Current head a2dc60e differs from pull request most recent head d1697c5. Consider uploading reports for the commit d1697c5 to get more accurate results

@@           Coverage Diff           @@
##             main    #3601   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         181      181           
  Lines        5376     5376           
=======================================
  Hits         4919     4919           
  Misses        457      457           

@peterzhuamazon peterzhuamazon changed the title Add new release notes scripts with 2.8.0 release notes Add new release notes scripts for consolidated release notes Jun 5, 2023
@peterzhuamazon peterzhuamazon merged commit bc3b9f0 into opensearch-project:main Jun 6, 2023
@peterzhuamazon peterzhuamazon deleted the release-notes-scripts branch June 6, 2023 18:43
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I added the comments forgot to hit review. Maybe create a followup PR?

Comment on lines +217 to +234


















Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up empty lines?

ORIG_URLS_ARRAY=()
RELEASE_NOTE_MD="$ROOT/release-notes-draft.md"
OLD_IFS=$IFS
RELEASENOTES_CATEGORIES="BREAKING,FEATURE#ADD,ENHANCE,BUG FIX,INFRASTRUCTURE,DOCUMENT,MAINT,REFACTOR"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spell check for all types

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jun 6, 2023

Hi @gaiksaya this is a temp script:

  1. That will be erased later on.
  2. That is by design so that all different types of category names by plugins can all be detected with wildcard after the given text.

Next step is to expend the releasenotes.py in our python code base.
This is just a quick replacement of the ODFE scripts.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants