Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bwc test workflow to onboard BWC test on distribution level #3039

Merged
merged 11 commits into from
Jan 20, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Dec 30, 2022

Signed-off-by: Zelin Hao [email protected]

Description

Update bwc test workflow to onboard BWC test on distribution level.
Basically, as in our repo, we are targeting to run BWC on the distribution level. The command in our bwctest.sh script will be running command ./gradlew bwcTestSuite -Dtests.security.manager=false -PcustomDistributionDownloadType=bundle with customDistributionDownloadType property set to bundle. In this way, the test cluster will be set up through the framework called within each plugin repo with the bundle distribution downloaded from our CI.

Issues Resolved

Part of #2870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team as a code owner December 30, 2022 22:54
@zelinh zelinh self-assigned this Dec 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #3039 (b47f9d8) into main (2a62814) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #3039   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         167      167           
  Lines        4602     4604    +2     
=======================================
+ Hits         4288     4290    +2     
  Misses        314      314           
Impacted Files Coverage Δ
src/test_workflow/bwc_test/bwc_test_runner.py 92.50% <0.00%> (ø)
src/test_workflow/bwc_test/bwc_test_suite.py 94.11% <50.00%> (ø)
src/paths/script_finder.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -46,9 +46,9 @@ def run(self) -> TestSuiteResults:
test_results = test_suite.execute_tests()
all_results.append(component.name, test_results)
else:
logging.info(f"Skipping bwc-tests for {component.name}, as it is currently not supported")
logging.info(f"Skipping bwc-tests for {component.name}, as it is currently not supported according to the test manifest.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does according to the test manifest mean here.

Copy link
Member

@peterzhuamazon peterzhuamazon Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logging.info(f"Skipping bwc-tests for {component.name}, as the bwc-test section is not declared under the component section in the test manifest")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log info means the component is declared in the manifest but it's not supported with bwc test. (e.g. ml-commons)
The one below means the component in our distribution manifest is not declared in the test manifest. e.g. (common-utils)

else:
logging.info(f"Skipping bwc-tests for {component.name}, as it is currently not declared in the test manifest")
logging.info(f"Skipping bwc-tests for {component.name}, as it is currently not declared in the test manifest.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dot.

Signed-off-by: Zelin Hao <[email protected]>
@zelinh zelinh merged commit 104cd71 into opensearch-project:main Jan 20, 2023
@zelinh zelinh deleted the bundle-bwc-test branch January 20, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants