Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated manifest for 1.2.1 with tags #1326

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Updated manifest for 1.2.1 with tags #1326

merged 3 commits into from
Dec 15, 2021

Conversation

davidlago
Copy link

@davidlago davidlago commented Dec 14, 2021

Signed-off-by: Dave Lago [email protected]

Description

Updated plugin references in the 1.2.1 manifest to point to the 1.2.1.0 tags instead of the 1.2 branches

  • OpenSearch
  • common-utils
  • job-scheduler
  • alerting
  • asynchronous-search
  • index-management
  • k-NN
  • security
  • performance-analyzer
  • anomaly-detection
  • cross-cluster-replication
  • sql
  • dashboards-reports
  • opensearch-observability

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@davidlago davidlago requested a review from a team as a code owner December 14, 2021 14:31
@dblock
Copy link
Member

dblock commented Dec 14, 2021

Has everyone tagged yet? Can we just do a bulk tags update in 1 PR?

@davidlago
Copy link
Author

No. I just checked the first one on the manifest (common-utils) and the last tag there is still 1.2.0.0

@peternied peternied changed the title Updated manifest for 1.2.1 with tag for security plugin Updated manifest for 1.2.1 with tags Dec 14, 2021
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidlago for getting this ball rolling. If you don't mind I'm going to use this as the focal update to make sure we've updated all of the ref targets to tags. I've updated the description on the issue. This way you can get all credit as the first to finish this post release task

If you do mind let me know, and we can break this apart.

@dblock
Copy link
Member

dblock commented Dec 14, 2021

For this PR change everything to tags/... and CI will keep failing until we're done.

@davidlago
Copy link
Author

Done. Assuming everyone's naming convention for tags is such that the tag is 1.2.1.0 except for the core project with 1.2.1.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@gaiksaya
Copy link
Member

Merging this PR as tests have passed now. Thanks @davidlago for the changes.

@gaiksaya gaiksaya merged commit decfa6a into opensearch-project:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants