Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enableRemoteStore parameter in opensearch-cluster-cdk #226

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

rishabh6788
Copy link
Collaborator

Description

This PR adds support for enableRemoteStore parameter in opensearch-cluster-cdk.
This will be used to run nightly benchmarks on remote-store enabled clusters.

Issues Resolved

opensearch-project/OpenSearch#8087

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #226 (34d08f6) into main (f53918c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #226   +/-   ##
=========================================
  Coverage     86.63%   86.63%           
  Complexity       27       27           
=========================================
  Files            77       77           
  Lines           202      202           
  Branches         11       11           
=========================================
  Hits            175      175           
  Misses           19       19           
  Partials          8        8           
Impacted Files Coverage Δ
...ts/jenkins/jobs/BenchmarkTestMultinode_Jenkinsfile 100.00% <ø> (ø)
tests/jenkins/jobs/BenchmarkTest_Jenkinsfile 100.00% <ø> (ø)

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rishabh6788, one nitpik here, thanks.

vars/runBenchmarkTestScript.groovy Outdated Show resolved Hide resolved
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block for now as it needs a version bump from another PR.

@peterzhuamazon peterzhuamazon merged commit 6d8eaea into opensearch-project:main Jun 23, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 23, 2023
…#226)

Signed-off-by: Rishabh Singh <[email protected]>
(cherry picked from commit 6d8eaea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants