Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding missing tests #749

Merged
merged 17 commits into from
Dec 19, 2024
Merged

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Dec 18, 2024

Description

DELETE /_search/scroll
POST /_snapshot/{repository}/{snapshot}
POST /_update_by_query/{task_id}/_rethrottle
PUT /_wlm/query_group/{name}

Issues Resolved

[#663 ]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Changes Analysis

Commit SHA: 9dedc0f
Comparing To SHA: 4231dad

API Changes

Summary

├─┬Paths
│ ├─┬/_update_by_query/{task_id}/_rethrottle
│ │ └─┬POST
│ │   └─┬Responses
│ │     └─┬200
│ │       └─┬application/json
│ │         └─┬Schema
│ │           └──[➕] properties (32056:15)
│ ├─┬/_search/scroll
│ │ └─┬DELETE
│ │   └─┬Responses
│ │     └──[➕] codes (28524:7)
│ └─┬/_search/scroll/{scroll_id}
│   └─┬DELETE
│     └─┬Responses
│       └──[➕] codes (28524:7)
└─┬Components
  └──[➕] responses (28524:7)

Document Element Total Changes Breaking Changes
paths 3 0
components 1 0
  • Total Changes: 4
  • Additions: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12410272391/artifacts/2342365934

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Spec Test Coverage Analysis

Total Tested
536 541 (100.93 %)

@Tokesh Tokesh marked this pull request as ready for review December 18, 2024 19:13
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some asks below.

Throw a retry into the flaky snapshot test.

tests/default/_core/update_by_query.yaml Outdated Show resolved Hide resolved
tests/default/_core/update_by_query.yaml Outdated Show resolved Hide resolved
tests/default/_core/update_by_query.yaml Outdated Show resolved Hide resolved
tests/snapshot/snapshot/snapshot.yaml Show resolved Hide resolved
@Tokesh
Copy link
Collaborator Author

Tokesh commented Dec 19, 2024

Some asks below.

Throw a retry into the flaky snapshot test.

Thank you! Ready for your review

@Tokesh Tokesh requested a review from dblock December 19, 2024 09:54
@dblock dblock merged commit a2afe56 into opensearch-project:main Dec 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants